fix(rikaicontent): Properly check for text areas and input elements when deciding to save cursor information on mousedown #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic required the text box to be in a `<form` element which is not often true. A follow up to this should be to also handle other cases like `content: editable`. I'm not sure how that works now though so maybe it's fine. Also, update the timeout for data_test.ts since it wasn't long enough to complete on the normal Github Codespace.
Codecov Report
@@ Coverage Diff @@
## main #1282 +/- ##
==========================================
+ Coverage 79.10% 79.62% +0.52%
==========================================
Files 7 7
Lines 3001 3004 +3
Branches 186 188 +2
==========================================
+ Hits 2374 2392 +18
+ Misses 622 607 -15
Partials 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
melink14
changed the title
melink14
added
the
self-approved
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
melink14
pushed a commit
that referenced
this pull request
Nov 21, 2022
## [2.4.28](v2.4.27...v2.4.28) (2022-11-21) ### Bug Fixes * **dict:** Update dictionaries to latest versions ([#1286](#1286)) ([0a8c9c8](0a8c9c8)) * **rikaicontent:** Properly check for text areas and input elements when deciding to save cursor information on mousedown ([#1282](#1282)) ([51d5ecc](51d5ecc))
|
🎉 This PR is included in version 2.4.28 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic required the text box to be in a
<form>element which is not often true.A follow up to this should be to also handle other cases like
content: editable. I'm not sure how that works now though so maybe it's fine.Also, update the timeout for data_test.ts since it wasn't long enough to complete on the normal Github Codespace.